feat: Add random sampling to HepMC3 reader #4678
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples/Io/HepMC3/include/ActsExamples/Io/HepMC3/HepMC3Reader.hpp
Outdated
Show resolved
Hide resolved
…:murnanedaniel/acts into feat_poisson_multiplicity_hepmc3_merging
paulgessinger
changed the title
… generators - Replace inputPath/inputPaths with Config::Input struct - Add multiplicityGenerator field to Input for per-input sampling - Forward declare MultiplicityGenerator to avoid header dependency - Add proper Python bindings with keyword argument constructor - Simplify validation logic and remove backward compatibility
…_poisson_multiplicity_hepmc3_merging
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add random sampling to HepMC3 reader
--- END COMMIT MESSAGE ---
If pile-up and hard scatter are being merged, it can be useful to randomly sample the number of pile-up per hard scatter vertex. This can now be done by passing a sampler to the HepMC3 reader.
This is backward compatible in case no sampler is provided. The number of pileup and hardscatter events is simply fixed, in that case.