-
Notifications
You must be signed in to change notification settings - Fork 218
feat: Add CI workflow to test Key4hep downstream consumers #4663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e6caa61
to
54bfdec
Compare
.github/workflows/builds.yml
Outdated
with: | ||
path: ${{ env.CCACHE_DIR }} | ||
key: ccache-${{ runner.os }}-${{ github.job }}-${{ env.CCACHE_KEY_SUFFIX }}-${{ github.sha }} | ||
restore-keys: | | ||
ccache-${{ runner.os }}-${{ github.job }}-${{ env.CCACHE_KEY_SUFFIX }}- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not entirely sure about this one here, because the run-lcg-view
action below also has ccache cacheing built in. IIUC, each job will create it's own ccache in any case, right? So there is no re-use across jobs. In that case, I think this could be removed again, and we can simply use the run-lcg-view
to cache build artifacts via ccache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in favor of run-lcg-view
builtin functionality. That will give slightly different cache keys, if that is a problem, I can roll this back to use consistent cache keys
|
Currently only builds k4ActsTracking (which is effectively empty at the moment, so there is not too much of a check here) and reports back similar to how EIC does it
54bfdec
to
e47e9cf
Compare
/rerun |
Add a CI workflow that builds Key4hep downstream consumers on top of Acts. In case of failure add a brief comment to the report and ping key4hep-contacts.
--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
@paulgessinger as just discussed via mattermost.