Skip to content

Conversation

dimitra97
Copy link
Contributor

@dimitra97 dimitra97 commented Aug 27, 2025

This PR:

  • Fixes the grid initialization of the multiwire volume builder to also pass the transform of the volume for the correct fill
  • Allows grid access in the MultiLayer Navigation Policy by using the GridAccessHelpers::accessLocal
  • Casts correctly the starting position and direction for the multilayer navigation - according to the axis definitions of the grid

It looks like fixes behavior in athena navigation for gen3 for the muon spectrometer (I hope one of the last fixes) - because before none surfaces were found

--- END COMMIT MESSAGE ---

Any further description goes here, @-mentions are ok here!

  • Use a conventional commits prefix: quick summary
    • We mostly use feat, fix, refactor, docs, chore and build types.
  • A milestone will be assigned by one of the maintainers

@github-actions github-actions bot added this to the next milestone Aug 27, 2025
@github-actions github-actions bot added the Component - Core Affects the Core module label Aug 27, 2025
junggjo9
junggjo9 previously approved these changes Aug 27, 2025
@acts-policybot acts-policybot bot dismissed junggjo9’s stale review August 27, 2025 21:51

Invalidated by push of b18762e

Copy link
Contributor

github-actions bot commented Aug 27, 2025

📊: Physics performance monitoring for 80310e2

Full contents

physmon summary

❗️: Downstream build failure

  • eic-shell (cc @acts-project/epic-contacts)

@dimitra97 dimitra97 requested a review from junggjo9 September 8, 2025 12:11
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. CI test failures should be transient

Copy link

@kodiakhq kodiakhq bot merged commit c09592a into acts-project:main Sep 10, 2025
41 checks passed
@andiwand andiwand modified the milestones: next, v43.3.0 Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants