-
Notifications
You must be signed in to change notification settings - Fork 320
I have created the clear_images.py file in the Scripts folder in the … #1237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I have created the clear_images.py file in the Scripts folder in the … #1237
Conversation
…backend app and then added the command in the docker compose file to run the file under the container of django_backend
✅ Deploy Preview for activist-org canceled.
|
Thank you for the pull request! ❤️The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR Commit Check
- The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.email
in their local activist repo (can be set withgit config --global user.email "GITHUB_EMAIL"
)
Hello @andrewtavis am requesting that you review my contribution |
Can you add a license header as the first line to your Python file as is done in the other ones, @Joshua-Tihabwangye? 😊 |
And you have a ruff error as well for an import you're not using, @Joshua-Tihabwangye :) You can see that here. There are a few more thing I'd do to finalize this like resetting some of the Docker settings, but if you wanted to send along the license header and remove the import then we should be good for a final review :) |
Yes, I am going to correct the ruff error and also the other license thing |
4fda00e Sends along some minor adjustments to the process so the Hmmm in writing it I'm seeing that the tests aren't being picked up 🤔 I'll take another look :) Ping @mattburnett-repo: Would be good to get your feedback here :) |
Hey @andrewtavis I'll take a look during the next work session in the morning. |
Thanks @mattburnett-repo! Tests are passing now :) Those are:
Let me know what you think! Thanks for the efforts here as well, @Joshua-Tihabwangye! Just wanting to make sure we're doing this as safe as possible 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM.
Minor suggestion to use existing settings.MEDIA_ROOT
var instead of duplicate IMAGE_DIR
.
ca70566 does some final edits here. I wasn't able to import the route from settings. Really not sure why, but it was giving me an import error and saying that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only other changes here would be super minor, so I'll approve and bring it in :) Thanks for the great first contribution, @Joshua-Tihabwangye, and also for the review, @mattburnett-repo! 😊
…backend app and then added the command in the docker compose file to run the file under the container of django_backend
Contributor checklist
Description
I've run the docker containers and it displayed the logs
Related issue