Skip to content

Added tests for Events page #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aasimsyed
Copy link
Collaborator

Contributor checklist


Description

Used "Organizations Page" tests as template to create "Events Page" tests.

Related issue

  • #ISSUE_NUMBER

Copy link

netlify bot commented Apr 26, 2025

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 99d5a15
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/68164a40a598370008e87152
😎 Deploy Preview https://deploy-preview-1234--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Copy link
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Looks like all the PRs aren't linked to your account, @aasimsyed 🤔 Do you want to follow the steps I mentioned in #1232 and then maybe you can do another commit or something to these? Maybe there's a way for you to force push to update the account 🤔

@andrewtavis
Copy link
Member

And can you help with the review here, @cquinn540? 😊

@andrewtavis
Copy link
Member

And @cquinn540 and @aasimsyed: Do you two want to maybe do a call in the coming days to do the reviews for all of @aasimsyed's PRs :)

@andrewtavis
Copy link
Member

Would be great if we could spend some time during the sync to bring all of these in, @cquinn540 and @aasimsyed :) Hope you both can make it!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving given feedback from @cquinn540 and all during the sync 🚀 Thanks, @aasimsyed!

@andrewtavis andrewtavis merged commit cc3f8f6 into activist-org:main May 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants