Skip to content

feat: wip - expanded map tooltip for events start of implementation #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025

Conversation

JerryW04
Copy link
Contributor

@JerryW04 JerryW04 commented Apr 25, 2025

Contributor checklist


Description

Add a WIP expanded tooltip for map markers in MediaMap.vue.

Displays a tooltip card showing the event title, organization, date/time, and location, each paired with an icon
Pulls the “Attend” button label from i18n and styles it consistently with the rest of the tooltip

Related issue

Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 791837f
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/681cecbc9400ba0008536880
😎 Deploy Preview https://deploy-preview-1231--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Copy link
Contributor

github-actions bot commented Apr 25, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo (can be set with git config --global user.email "GITHUB_EMAIL")

@andrewtavis
Copy link
Member

Quick check in here, @JerryW04 :) What else is left that it's WIP? Could you send along a screenshot of how it looks currently? The frontend check is just Prettier saying that components/media/MediaMap.vue isn't formatted correctly. Maybe you could install the prettier extension and then format the file?

I can also handle the i18n check erorr if you'd like some assistance with it. Checking the error, what our system is saying is:

There is 1 i18n key that is not named correctly. Please rename the following key [current_key -> suggested_correction]:

i18n.components.tooltip_menu_search_result_event.attend -> i18n.components._global.attend

Really excited to have so much progress here already! 😊

@andrewtavis
Copy link
Member

Hey @JerryW04 👋 Doing a quick check in :) Let us know if you need any support with the failing tests or other work here 😊

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work here, @JerryW04! We're in the midst of finalizing a bunch of PRs today, so I hope it's ok that I took this one over :)

Results of my edits are below:

Screenshot 2025-05-08 at 19 38 12

I think that it makes sense for us to give up on the idea of having the image in the tooltip as it's just too much. We'd be asking MapLibre to do some things that it's not set up to do out of the box, and best to avoid that for now. We do have a left border based on the event type, and there's added styling so the close button is a bit easier to see 😊

@andrewtavis andrewtavis merged commit 90e1a59 into activist-org:main May 8, 2025
7 checks passed
@andrewtavis andrewtavis mentioned this pull request May 8, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants