-
Notifications
You must be signed in to change notification settings - Fork 316
feat: wip - expanded map tooltip for events start of implementation #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request! ❤️The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR Commit Check
- The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.email
in their local activist repo (can be set withgit config --global user.email "GITHUB_EMAIL"
)
Quick check in here, @JerryW04 :) What else is left that it's WIP? Could you send along a screenshot of how it looks currently? The frontend check is just Prettier saying that I can also handle the i18n check erorr if you'd like some assistance with it. Checking the error, what our system is saying is:
Really excited to have so much progress here already! 😊 |
Hey @JerryW04 👋 Doing a quick check in :) Let us know if you need any support with the failing tests or other work here 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work here, @JerryW04! We're in the midst of finalizing a bunch of PRs today, so I hope it's ok that I took this one over :)
Results of my edits are below:

I think that it makes sense for us to give up on the idea of having the image in the tooltip as it's just too much. We'd be asking MapLibre to do some things that it's not set up to do out of the box, and best to avoid that for now. We do have a left border based on the event type, and there's added styling so the close button is a bit easier to see 😊
Contributor checklist
Description
Add a WIP expanded tooltip for map markers in MediaMap.vue.
Displays a tooltip card showing the event title, organization, date/time, and location, each paired with an icon
Pulls the “Attend” button label from i18n and styles it consistently with the rest of the tooltip
Related issue