Skip to content

Fix spagoop analysis failure due to missing 'tld' column in LEFT JOIN with exploded_dns #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix spagoop analysis failure due to missing 'tld' column in LEFT JOIN with exploded_dns #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions analysis/spagooper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,9 +676,16 @@ func (analyzer *Analyzer) ScoopDNS(ctx context.Context, bars *tea.Program) error
-- keep tlds which had zero non-dns-server ips in direct connections
),
historical AS (
SELECT min(first_seen) AS first_seen, cutToFirstSignificantSubdomain(fqdn) as tld
FROM metadatabase.historical_first_seen
LEFT JOIN exploded_dns USING tld
SELECT
min(first_seen) AS first_seen,
tld
FROM (
SELECT
first_seen,
cutToFirstSignificantSubdomain(fqdn) AS tld
FROM metadatabase.historical_first_seen
) AS historical
LEFT JOIN zeeklogs.exploded_dns USING (tld)
GROUP BY tld
),
totaled_exploded AS (
Expand Down