Correctly capture return code from run-helper.sh after receiving a SIGTERM or SIGINT #3788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a subtle bug in the
run.shscript when usingrunWithManualTrap. When a SIGINT or SIGTERM is sent, thewaitcommand will be interrupted, causing the return code to be set to143. It then does its subsequent checks on the incorrect return code, so ifrun-helper.shdid exit with a return code of 2, the process would not be restarted.This fix introduces a
signaledflag to track when the trap was run. In such cases, the wait will simply be run again.