Update dockerfile to ubuntu:24.04 #3771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to cleaning up the apt lists, remove downloaded packages This will reduce the size of the layers by a litte bit
Update from Jammy to Noble. Add the dotnet runtime dependencies to Dockerfile
Fill in missing linux ARGS
|
Also, I don't know if your test suite will cover the Dockerfile, but I can confirm that I am using the above as a base for my self hosted runner. So its building and running with the github api. The only change I had to make to a downstream Dockerimage was to add "--break-system-packages" to the subsequent pip3 command in my local build image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile has gotten pretty stale, and as a base for build images,
leaves a lot of CVEs and vulnerabilities which are easily fixed by moving to a more recent base.
Update it to the most recent Ubuntu LTS.
I'm not sure if there is a more recent version of the dotnet image, but it seemed simpler to
me to follow the installation instructions for action-runner in the Dockerfile.
Lastly, I added apt-get upgrade to the beginning of each apt command,
which will keep the image up to date with the source image if it is rebuilt,
and apt-get clean to the end of each apt command, which will keep the resultant
layers smaller by removing apt download cache leftovers