Skip to content

Conversation

@Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Oct 27, 2025

In #2187 we removed the need for transcripts to be visible, but somehow forgot to remove Failed Example 3 of an invisible transcript (which is now the same as Passed Example 3).

Closes issue(s):

  • N/A

Need for Call for Review:
This will require a 1 week Call for Review.


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@Jym77 Jym77 self-assigned this Oct 27, 2025
@Jym77 Jym77 added the Rule Update Use this label for an existing rule that is being updated label Oct 27, 2025
@Jym77 Jym77 requested a review from giacomo-petri October 27, 2025 14:34
@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 0616e8e
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/68ff82c6144bbf0008ebafa7
😎 Deploy Preview https://deploy-preview-2367--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Oct 28, 2025
@Jym77
Copy link
Collaborator Author

Jym77 commented Oct 28, 2025

Call for Review ends on November 4th.

@mraccess77
Copy link

I think transcripts should be visible - how would a person with low vision know it's there or read it without forcing them to use a screen reader?

@Jym77
Copy link
Collaborator Author

Jym77 commented Nov 3, 2025

I think transcripts should be visible - how would a person with low vision know it's there or read it without forcing them to use a screen reader?

The requirement for visibility of transcript has been clarified in this WCAG discussion, where the conclusion is very clear. This is why we did #2187, this is just the stuff we missed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants