[80af7b] Focusable element has no keyboard trap - move Failed Example 2 to passed since it's currently passing the ACT rule #2340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomo-petri
requested review from
HelenBurge,
Jym77,
WilcoFiers,
carlosapaduarte,
dan-tripp-siteimprove,
daniel-montalvo,
dd8,
kengdoj,
tbostic32 and
tombrunet
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WilcoFiers
requested changes
Jul 24, 2025
|
Moved from failed to passed, as per CG meeting. |
carlosapaduarte
approved these changes
Jul 24, 2025
daniel-montalvo
changed the title
daniel-montalvo
approved these changes
Jul 25, 2025
WilcoFiers
approved these changes
Aug 7, 2025
dan-tripp-siteimprove
approved these changes
Aug 7, 2025
|
Call for review ends on August 18th |
giacomo-petri
added
Review Call 1 week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2314
Description:
Failed Example 2 is currently passing the ACT rule because it traps the user when navigating forward, but not backward. According to the Background note:
Given this, I'm removing the specific test case.
Need for Call for Review:
This will require a 1 week Call for Review