Add accessibility support note about aria-busy to all rules with accessibility tree as input aspect #2160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssibility tree as input aspect
carlosapaduarte
added
the
Rule Update
Collaborator
|
Should we contemplate including it in the rule template as well? Otherwise, there's a chance we might overlook this aspect when creating new rules. Alternatively, we could explore the option of implementing a script to automatically apply/remove this item (and potentially others in the future) to/from all rules. |
Jym77
approved these changes
Feb 29, 2024
Collaborator
Jym77
left a comment
Jym77
left a comment
There was a problem hiding this comment.
I agree that it would be good to auto-inject this kind of things (we had case in the past with an assumption when Language is an input aspect) 🤔
tbostic32
approved these changes
Mar 27, 2024
giacomo-petri
requested changes
Jun 20, 2024
Collaborator
giacomo-petri
left a comment
giacomo-petri
left a comment
There was a problem hiding this comment.
Sorry, I thought I had marked it as "request changes," but I never started the review. Please refer to my previous comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add accessibility support note about aria-busy to all rules with accessibility tree as input aspect
Closes issue(s):
Need for Call for Review:
This will not require a Call for Review: changes to accessibility support
How to Review And Approve