feat: l2 token approval flow #2260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ihor Farion <[email protected]>
grasphoper
changed the title
Signed-off-by: Ihor Farion <[email protected]>
grasphoper
commented
May 21, 2025
| I can of course just introduce a new key for L2 token approvals, but it seems redundant. Instead, the key could be smth like: | ||
| `bridgeAllowance_${chainId}_${token}_${userAddress}_targetContract:${targetContract}`; | ||
| */ | ||
| const allowance = await erc20.allowance(senderAddress.toAddress(), bridgeAddress.toAddress()); |
There was a problem hiding this comment.
This comment relates to cache operations in a similar L1 token approval fn.
grasphoper
commented
May 21, 2025
| // Bridges that require specific approvals should override this method. | ||
| public requiredTokenApprovals(): { token: EvmAddress; bridge: EvmAddress }[] { | ||
| return []; | ||
| } |
There was a problem hiding this comment.
I think returning EvmAddresses is fine here
grasphoper
requested review from
mrice32,
nicholaspai,
pxrl,
james-a-morris,
dohaki and
bmzig
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some L2 -> L1 bridge objects sometimes require ERC20s to be approved to their associated bridge contracts. Example: Hyperlane requires
ezETHto be approved for spending by aHYPERLANE_ROUTER.This is why we implement a token approval flow for L2 bridges similar to L1 token approval flow.
Approval + xERC20 rebalancing test after change:
✅ rebalance
✅ token approval happened on a prev. relayer run.