Update with various suggested PRs #39
Conversation
If there are no children, then the output could not have changed in this case.
This case is equivalent to the unchanged source case.
Dont update if unchanged
Add remarkable plugins support
…ent-wrapper Use contentWrapper prop to define the wrapper for the parsed content
- Merge content method into render method. - Move sort methods to be ordered: lifecycle, custom, then render.
|
since this has gone ignored, perhaps you'd like to publish your fork to npm? namespace it under your user if you'd prefer |
|
@DanielFGray - Sure is great to have maintained projects, eh! While I'm flattered by your suggestion… I'm not confident that I'm the right person to take this task on… though anything is possible. |
|
Personally, I don't think whether you're the right person is even a question, you've already done the work of merging other pulls, and that already makes you the right person from where I'm standing. I'm not asking you to "maintain" it anymore than it is here, but to just make your work more accessible. |
|
Hi @beausmith , @DanielFGray , Do you know if this project is still active? Lifecycle methods are changing https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html, and react gives warning I believe a small change might be required for this project, and @beausmith branch looks like the best starting point.. any thoughts on this? Thank you, |
|
Any update on this? |
|
@alexmorleyfinch - I wish I had the time to maintain a project like this… alas, I do not. |
7 participants
@acdlite - I needed a bunch of bits which other people had solved so I pulled or reimplemented them. It would be great to get all this pulled over to your "official" repo.
Please review carefully, I'm sure there are a few things which could be done be a better way… specifically the creation of
dist/index.js.