feat: additional gcp rules #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rules to detect: - IAM Custom Role Created - IAM Custom Role Deleted - IAM Member assigned role of type admin or owner - Service Account Access Key Created - Service Account Access Key Deleted - Storage Bucket IAM Permissions Modified - Logging Bucket Deleted
murtaza-u
commented
Jun 10, 2025
rules/cloud/gcp/ak-rules/gcp_iam_member_assigned_admin_or_owner_role.yml
Show resolved
Hide resolved
achrefbensaad
approved these changes
Jun 10, 2025
| detection: | ||
| selection: | ||
| gcp.audit.protoPayload.methodName: google.iam.admin.v1.DeleteRole | ||
| gcp.audit.protoPayload.response.deleted: "true" |
There was a problem hiding this comment.
is this required ? does it expect that the deletion is successful to match ?
There was a problem hiding this comment.
Yes. The deletion can fail if the role is in use.
rules/cloud/gcp/ak-rules/gcp_iam_member_assigned_admin_or_owner_role.yml
Show resolved
Hide resolved
|
can you please add logging bucket creation & update rules (two separate rules) |
Will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Added additional GCP rules
Changelog
new: additional GCP detection rules
Example Log Event
Fixed Issues
SigmaHQ Rule Creation Conventions