-
Notifications
You must be signed in to change notification settings - Fork 42
Updating test results for tech/html/input/input-number #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
mfairchild365
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this! please see my comments :)
| "feature_assertion_id": "convey_name", | ||
| "result": "pass", | ||
| "notes": "announced the name when entering the input and did not automatically switch to forms mode." | ||
| "result": "fail", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ouch. that's a bummer, but can confirm. Other inputs are fine too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this is intentional though, as when I navigated this way it went from [input label] to [input], so I never missed the label, it just doesn't get a label on its own when you land on it.
| "feature_assertion_id": "convey_change_in_value", | ||
| "result": "pass" | ||
| "result": "fail", | ||
| "notes": "each keypress was echoed and the value was changed to \"two11\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might pass. If FF lets you enter invalid characters but still echos them. What do you mean by the value was changed to "two11" - does that match what you typed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It matches what I typed, I was able to both add text before the value "two11" but also replace the value completely. If its a pass I can switch it.
Updated test results for input-number for all desktop browser + SR combinations.
Some changed test results.
This PR closes issues #261, #260, and #259.