apg-menu-button-actions-active-descendent test results update #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 9, 2025
mfairchild365
requested changes
Sep 12, 2025
Contributor
mfairchild365
left a comment
mfairchild365
left a comment
There was a problem hiding this comment.
See my review comments. I'm not quite understanding why this would now pass the assertion for aria-controls to convey its presence.
Contributor
Author
|
@mfairchild365 tests fixed, let me know if I can merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating test results for apg-menu-button-actions-active-descendent.
This PR closes issues #292 and #291 though I was unable to recreate the issues mentioned in that test result.