Improve pdf download #22922
Open
Improve pdf download #22922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… across multiple languages.
…es across multiple languages.
maliming
reviewed
May 19, 2025
modules/docs/src/Volo.Docs.Domain/Volo/Docs/Projects/Pdf/DocsProjectPdfGeneratorOptions.cs
Outdated
Show resolved
Hide resolved
oykuermann
requested changes
May 20, 2025
There was a problem hiding this comment.
- We can change 'in' with 'to' : PDF generation has started. Once completed, you can check if the file has been added to the PDF files section.
- We don't need to write 'PDF generation started' two times.
- We can't see PDF file before reopening the modal:
screen-capture.-.2025-05-20T114448.491.webm
oykuermann
approved these changes
May 20, 2025
maliming
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/volosoft/vs-internal/issues/6542
From now on, only the admin will be able to generate PDFs. If a PDF exists, a download option will be shown in the UI