Fixes test DeserializeScalarEdgeCases for non english cultures.
#793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test fails if the machine culture does not use the dot decimal separator. This is caused due to `object.ToString()` being used that is culture sensitive. This commit fixes the test using `string.Format` with `CultureInfo.InvariantCulture`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The test
DeserializeScalarEdgeCasesfails if the machine culture does not use the dot decimal separator. This is caused due toobject.ToString()being culture sensitive for floats and doubles.This PR addresses partially #792. For a full explanation refer to that issue.
Fix
This PR fixes the test using
string.FormatwithCultureInfo.InvariantCultureinstead ofobject.ToString()