Nullable fixes in non-public code #1064
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is a possibility that ToString methods return null
nll value will be correctly handled later in the code by Traverse method
reorder registration component, to make analyzer happy the behavior should be the same, as it is lazy registration
reorder registration component, to make analyzer happy the behavior should be the same, as it is lazy registration
remove redundant nullability, according compiler all cases are covered by non-null value
handle possibility when get method can be null
Handle case when Value can property can be null
Fixes potential nullable chain
ignore potential warning, either getter or setter needs to be available
Kielek
changed the title
|
@aaubry, could you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a lot of warnings related to nullable annotations. All of them are related only to non-public contracts.
It can be fixed also for public classes, but it can be considered as a braking changes, so it should be candidate for separate PR.
While reviewing, you can consider commit by commit reviews.