Improve generation of the _choice suffix for ProtoBuf #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 10, 2025 15:42
trying to generate polymorphic protobuf messages leads to the necessary generation of choice messages. naming them is now moved to the naming.py utilities
the directory structure for the protobuf generator test cases is now aligned with the other generators
bring back the two new lines between protobuf package name and message definitions
align the expected output of the protobuf generator with the latest version of aas-core-meta
|
@TomGneuss do you happen to remember why we decided not to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
proto_naming.interface_namewas previously unused since ProtoBuf does not support interfaces anyway. It is now used to generate the_choicesuffix for message definitions that try to mimic polymorphism with theoneofkeyword. This reduces the risk of inconsistent naming when generating the ProtoBuf message definitions.As part of this PR, comments regarding ProtoBuf intricacies have been refined.
Also, the files for the ProtoBuf test cases have been moved slightly to align with the directory structure of the other generator tests.