Skip to content

Added an option to pass hidden element template #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added an option to pass hidden element template #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions dist/ng-sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,9 @@
longTouchCancel, // cancel long touch
longTouchTimer, // timer promise for the long touch on iOS devices
dragHandled, //drag handled.
createElementByOptionOrTagName, //generic function to generate element by optional template or tagName
createPlaceholder,//create place holder.
createHiddenElement,//create hidden place element.
isPlaceHolderPresent,//is placeholder present.
isDisabled = false, // drag enabled
escapeListen, // escape listen event
Expand Down Expand Up @@ -663,16 +665,24 @@
angular.element($document[0].body).unbind('keydown', escapeListen);
});

createPlaceholder = function (itemScope) {
if (typeof scope.sortableScope.options.placeholder === 'function') {
return angular.element(scope.sortableScope.options.placeholder(itemScope));
} else if (typeof scope.sortableScope.options.placeholder === 'string') {
return angular.element(scope.sortableScope.options.placeholder);
createElementByOptionOrTagName = function (itemScope, optionName) {
if (typeof scope.sortableScope.options[optionName] === 'function') {
return angular.element(scope.sortableScope.options[optionName](itemScope));
} else if (typeof scope.sortableScope.options[optionName] === 'string') {
return angular.element(scope.sortableScope.options[optionName]);
} else {
return angular.element($document[0].createElement(itemScope.element.prop('tagName')));
}
};

createPlaceholder = function (itemScope) {
return createElementByOptionOrTagName(itemScope, 'placeholder');
};

createHiddenElement = function (itemScope) {
return createElementByOptionOrTagName(itemScope, 'hiddenElementTemplate');
};

/**
* Listens for a 10px movement before
* dragStart is called to allow for
Expand Down Expand Up @@ -773,7 +783,7 @@
placeHolder.css('width', $helper.width(scope.itemScope.element) + 'px');
placeHolder.css('height', $helper.height(scope.itemScope.element) + 'px');

placeElement = angular.element($document[0].createElement(tagName));
placeElement = createHiddenElement(scope.itemScope);
if (sortableConfig.hiddenClass) {
placeElement.addClass(sortableConfig.hiddenClass);
}
Expand Down
Loading