feat(lib): add a config package to load application configuration using Viper #28
+61
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| UploaderPartSizeMB int64 `mapstructure:"uploader_part_size_mb"` | ||
| UploaderConcurrency int `mapstructure:"uploader_concurrency"` | ||
| DownloaderPartSizeMB int64 `mapstructure:"downloader_part_size_mb"` | ||
| DownloaderConcurrency int `mapstructure:"downloader_concurrency"` |
There was a problem hiding this comment.
whats the use of the mapstructure tag?
There was a problem hiding this comment.
It's used by Viper to map the field name in the configuration file to the name in our Go struct.
For example,
uploader_concurrency from the YAML file should be mapped to UploaderConcurrency in our struct.
|
related to #25 |
…lling of values from YAML file to struct
|
@Ashish-walkingn8mare Added Credential Store. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a new
configpackage that loads application configuration from a YAML fileespressoconfig.yamlat startup.Why is this change necessary?
Centralizing configuration management makes the application more maintainable.
Loading configuration from a YAML file allows easier updates without modifying code.
Module
libRelated Issues
Related to #25