Dmytro/add ng state format #1007
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_task is called first time
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 172 172
Lines 8389 8404 +15
=========================================
+ Hits 8389 8404 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
supersergiy
reviewed
Aug 5, 2025
| @@ -113,7 +113,7 @@ def create_trace_feedback_v0_task( | |||
| raise ValueError("trace_feedback_v0 requires 'task_id' in kwargs") | |||
|
|
|||
| # Get the original task | |||
| original_task = get_task(project_name=project_name, task_id=original_task_id) | |||
| original_task = get_task(project_name=project_name, task_id=original_task_id, process_ng_state=False) | |||
There was a problem hiding this comment.
Why does this need process_ng_state=False?
There was a problem hiding this comment.
Because here we use get_task just to get original_task to create other task, I think we do not need to generate ng_state in this case, we just copy ng_state from original task in format { "seed_id": ... }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.