Skip to content

Rails v8.0 compability #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rails v8.0 compability #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0815a3
Drop use of deprecated Rails::ConsoleMethods
rstammer Jun 6, 2025
4a20efa
Update actions/checkout and actions/cache for GitHub actions workflow
rstammer Jun 6, 2025
6984a24
Use newer Ruby version for GitHub actions
rstammer Jun 6, 2025
7e61e72
Fixiate platform for GitHub actions
rstammer Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2.2
ruby-version: 3.3
bundler-cache: true
# https://github.com/actions/cache/blob/master/examples.md#ruby---bundler
- uses: actions/cache@v1
- uses: actions/cache@v4
with:
path: vendor/bundle
key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
Expand Down
11 changes: 6 additions & 5 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ PATH
specs:
jupyter_on_rails (0.13.0)
daru
iruby
iruby (>= 0.8.1)
railties

GEM
Expand Down Expand Up @@ -95,15 +95,16 @@ GEM
io-console (0.5.11)
irb (1.4.1)
reline (>= 0.3.0)
iruby (0.7.4)
iruby (0.8.2)
data_uri (~> 0.1)
ffi-rzmq
irb
logger
mime-types (>= 3.3.1)
multi_json (~> 1.11)
native-package-installer
json (2.6.3)
language_server-protocol (3.17.0.3)
logger (1.7.0)
loofah (2.21.3)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
Expand All @@ -115,7 +116,6 @@ GEM
minitest (5.19.0)
multi_json (1.15.0)
multipart-post (2.1.1)
native-package-installer (1.1.4)
nio4r (2.5.7)
nokogiri (1.15.2)
mini_portile2 (~> 2.8.2)
Expand Down Expand Up @@ -188,6 +188,7 @@ GEM

PLATFORMS
ruby
x86_64-linux

DEPENDENCIES
bump
Expand All @@ -197,4 +198,4 @@ DEPENDENCIES
rubocop

BUNDLED WITH
2.2.22
2.6.8
2 changes: 1 addition & 1 deletion jupyter_on_rails.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'rake'
spec.add_development_dependency 'rubocop'

spec.add_dependency 'iruby'
spec.add_dependency 'iruby', '>= 0.8.1'
spec.add_dependency 'railties'

spec.add_dependency 'daru'
Expand Down
2 changes: 0 additions & 2 deletions lib/jupyter_on_rails/initializer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,10 @@ def load_rails_environment
end

def setup_console_methods
require 'rails/console/app'
IRuby::Kernel
.instance
.instance_variable_get(:@backend)
.instance_variable_get(:@main)
.extend(Rails::ConsoleMethods)
end

def setup_sandbox_transaction
Expand Down