Skip to content

Conversation

luke-wriglesworth
Copy link

Description

Removed an incorrect type: string declaration from the Contact property in the Quote schema. The Contact property already uses $ref to reference the Contact schema, so having an additional type: string declaration is invalid OpenAPI syntax.

This can cause code generation tools to incorrectly interpret the Contact property. For example, the current version of openapi-generator-cli generates the Contact property of Quote as a string.

Release Notes

This change fixes a mistake in the Quote schema where the Contact property had both a $ref and a type: string sibling. The change ensures compliance with the OpenAPI specification and prevents issues with code generators.

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

PETOSS-819

Copy link

Thanks for raising an issue, a ticket has been created to track your request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant