Skip to content

Conversation

@ZANX3Y
Copy link
Contributor

@ZANX3Y ZANX3Y commented Nov 17, 2025

Description

When using Sodium, fluids were not rendered correctly. This prevented players from seeing anything while submerged with X-ray enabled.
The new implementation should now be on par with Indigo.

Testing

Tested manually. Couldn't update Sodium screenshot templates in the automated tests, since screenshots produced by clientGameTest on my PCs always slightly differ from those in CI (seems like some sort of window scaling issue on my end).

Edit: I decided to see if it would work through X instead of Wayland. It sure did.
"Wayland breaks everything" lives on.

References

X-Ray off
off

Indigo
indigo

Sodium (pre fix)
err

Sodium (post fix)
fixed

ZANX3Y and others added 4 commits November 17, 2025 21:38
It should now be consistent enough to use the same screenshot templates for both Sodium and Indigo. At least it is on my graphics drivers. We'll see how xvfb handles it...
Copy link
Member

@Alexander01998 Alexander01998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you! I've been able to take this further and make X-Ray on Sodium look virtually identical to X-Ray on Indigo.

@Alexander01998 Alexander01998 added type:bugfix This can be released as a patch. category:render status:confirmed area:compatibility status:never-stale Prevents StaleBot from marking this item as stale. labels Nov 18, 2025
@Alexander01998 Alexander01998 added this to the v7.51.2 milestone Nov 18, 2025
@Alexander01998 Alexander01998 added status:merged This pull request has been merged, even if GitHub says otherwise. and removed status:confirmed status:never-stale Prevents StaleBot from marking this item as stale. labels Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:compatibility category:render status:merged This pull request has been merged, even if GitHub says otherwise. type:bugfix This can be released as a patch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants