-
Notifications
You must be signed in to change notification settings - Fork 58
FED-4063 Set up gha-dart-oss #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/ci.yml
Outdated
additional-checks: | | ||
no_entrypoint_imports | ||
|
||
test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because I changed this name, I'll update Rosie to look for the updated check names before we merge this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#nit this job also has a couple checks on generated files (that they're up to date, that things analyze cleanly before/after a build); could we update the name to reflect that?
test: | |
test_and_check_generated_files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
.github/workflows/ci.yml
Outdated
additional-checks: | | ||
no_entrypoint_imports | ||
|
||
test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#nit this job also has a couple checks on generated files (that they're up to date, that things analyze cleanly before/after a build); could we update the name to reflect that?
test: | |
test_and_check_generated_files: |
|
||
jobs: | ||
publish: | ||
uses: Workiva/gha-dart-oss/.github/workflows/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tl;dr we're good, posting for posterity
At first I thought this wasn't going to work once we switch to Dart 3, since it doesn't have --force
(see here), and this repo currently has warnings when analyzing the files in tools/analyzer_plugin.
But, it looks like they fixed that in dart-lang/pub#3630 (somewhere from Dart 3.3.0 to 3.4.0), so we don't have to worry about it!
In 3.4.0+, there's only a warning about tools/
, but I don't think that'll prevent the package from publishing:
Validating package... (8.2s)
Package validation found the following potential issue:
* Rename the top-level "tools" directory to "tool".
The Pub layout convention is to use singular directory names.
Plural names won't be correctly identified by Pub and other tools.
See https://dart.dev/tools/pub/package-layout.
The server may enforce additional checks.
Package has 1 warning.
So we're all good here; just wanted to note that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Yeah I was wondering if that thread was solved in some other way! Thanks for checking!
4f3885d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
We should set up gha-dart-oss so we can:
QA instructions