Skip to content

Conversation

sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented Aug 8, 2025

We should set up gha-dart-oss so we can:

  • take advantage of shared workflows
  • use the publish workflow to auto-publish on merge 🎉

QA instructions

  • CI passes
  • All steps previously run in CI are still running even if some of them are in the shared jobs now
  • When this merges, follow along to make sure the package actually publishes

additional-checks: |
no_entrypoint_imports

test:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I changed this name, I'll update Rosie to look for the updated check names before we merge this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#nit this job also has a couple checks on generated files (that they're up to date, that things analyze cleanly before/after a build); could we update the name to reflect that?

Suggested change
test:
test_and_check_generated_files:

@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review August 8, 2025 23:05
@btr-rmconsole-3 btr-rmconsole-3 bot changed the title Set up gha-dart-oss FED-4063 Set up gha-dart-oss Aug 11, 2025
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

additional-checks: |
no_entrypoint_imports

test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#nit this job also has a couple checks on generated files (that they're up to date, that things analyze cleanly before/after a build); could we update the name to reflect that?

Suggested change
test:
test_and_check_generated_files:


jobs:
publish:
uses: Workiva/gha-dart-oss/.github/workflows/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr we're good, posting for posterity

At first I thought this wasn't going to work once we switch to Dart 3, since it doesn't have --force (see here), and this repo currently has warnings when analyzing the files in tools/analyzer_plugin.

But, it looks like they fixed that in dart-lang/pub#3630 (somewhere from Dart 3.3.0 to 3.4.0), so we don't have to worry about it!

In 3.4.0+, there's only a warning about tools/, but I don't think that'll prevent the package from publishing:

Validating package... (8.2s)
Package validation found the following potential issue:
* Rename the top-level "tools" directory to "tool".
  The Pub layout convention is to use singular directory names.
  Plural names won't be correctly identified by Pub and other tools.
  See https://dart.dev/tools/pub/package-layout.
The server may enforce additional checks.

Package has 1 warning.

So we're all good here; just wanted to note that!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Yeah I was wondering if that thread was solved in some other way! Thanks for checking!

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@sydneyjodon-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-2 btr-rmconsole-2 bot merged commit 6484dff into master Aug 25, 2025
17 checks passed
@btr-rmconsole-2 btr-rmconsole-2 bot deleted the set-up-gha-dart-oss branch August 25, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants