fix: Add fallback to our inputs for border radius #3539
Merged
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-input-fallback
|
| Run status |
|
| Run duration | 02m 24s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
86
|
Skipped
|
0
|
Passing
|
843
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.34%
|
|
|---|---|
|
Untested elements
|
1533
|
|
Tested elements
|
365
|
Accessibility
99.31%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
77
|
mannycarrera4
commented
Oct 20, 2025
alanbsmith
approved these changes
Oct 27, 2025
| system: { | ||
| shape: { | ||
| //TODO: in v4 Tokens and v15, we should replace this forward fit token with the actual token value | ||
| sm: '--cnvs-sys-shape-sm', // this should be set to 8px |
There was a problem hiding this comment.
This is a non-blocking question, and more of a design decision I'm trying to understand.
Why did you choose to do it like the above instead of like this below?
sm: cssVar(forwardFitTokens.system.shape.sm, system.shape.x1Half),I don't have a preference, but I was wondering if you do.
There was a problem hiding this comment.
ahh I can do that, i think in my head i can see the style property and then know that it is forward fitted, no preference
There was a problem hiding this comment.
That would make sense too. I don't think there's a right or wrong here. The way I wrote it above prevents someone from accidentally putting a different default value for the token.
alanbsmith
approved these changes
Oct 27, 2025
mannycarrera4
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3538
Release Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)