Skip to content

Conversation

johnbillion
Copy link
Member

@johnbillion johnbillion commented Sep 5, 2025

Fixes #175.

To test

  1. Make an update to a legacy container config in update.php
  2. Run php update.php
  3. Confirm the corresponding images/x.y files were not updated

Copy link

github-actions bot commented Sep 5, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: johnbillion <[email protected]>
Co-authored-by: desrosj <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

These images are no longer rebuilt, so these changes were never tested and released.
These containers are no longer built, so these changes were never tested and released.
Copy link
Member

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were 3 commits making changes to these legacy containers since they were removed from the build workflows that I've reverted here.

It's highly unlikely that these will ever be rebuilt again. But just in case, I think it makes sense to return these images back to the state of their last successful build and publishing.

@desrosj
Copy link
Member

desrosj commented Sep 12, 2025

@johnbillion There are a few other open PRs that would update legacy containers without this PR being merged first.

I wanted to make sure that you agreed with removing the changes to the Dockerfiles for these older versions that remain unpublished before merging.

@johnbillion johnbillion merged commit 33d2d37 into trunk Sep 13, 2025
22 checks passed
@johnbillion johnbillion deleted the legacy-containers branch September 13, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent changes to legacy containers
2 participants