Skip to content

(PoC) Overhaul condition UI #6304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 82 commits into
base: 6.2
Choose a base branch
from
Draft

(PoC) Overhaul condition UI #6304

wants to merge 82 commits into from

Conversation

Cyperghost
Copy link
Contributor

@Cyperghost Cyperghost commented May 25, 2025 •
edited
Loading

Closes #5984

TODO:

  • Deprecate the 'old' ConditionHandler functions
  • Add migration functions
  • Add wcf1_user_group_assignment .conditions to install.sql
  • Remove old ObjectTypes and ObjectTypeDefinitions for UserGroupAssignment
  • Handle delete condition types
  • Handle when a value is deleted from a SelectFormField so that no exception is thrown
  • Condition for User options #6318

@Cyperghost Cyperghost requested a review from dtdesign May 25, 2025 08:09
@Cyperghost Cyperghost force-pushed the 6.3-condition branch 3 times, most recently from 762479e to afd7d4b Compare May 27, 2025 10:16
dtdesign
dtdesign requested changes Jun 1, 2025
View reviewed changes
dtdesign
dtdesign requested changes Jun 3, 2025
View reviewed changes
This was referenced Jun 10, 2025
Merged
Merged
Cyperghost and others added 22 commits July 14, 2025 10:04
@Cyperghost
Implement basic condition types and provider
5967ec8
@Cyperghost
Migrate user group assignment form to form builder
12055c4
@Cyperghost
Implement condition form container
815a8dc
@Cyperghost
Load and save conditions
985fbd1
@Cyperghost
Implement condition date form field
234679b
@Cyperghost
Use the new condition system in the user group assignment handler
abc4eb6
@Cyperghost
Remove unnecessary ConditionHandler calls
67f0a77
@Cyperghost
Add some phrases
3fcf09d
@Cyperghost
Reformate code
a0e4c73
@Cyperghost
Handle invalid value
5f4ffd3
@Cyperghost
Remove unnecessary conditions
2d04ee6
@Cyperghost
Check whether an invalid date value was sent
47c505e
@Cyperghost
Add event for condition provider
4757c9e
@Cyperghost
Add condition types for user is and is not in group
9bc6dda
@Cyperghost
Add condition types for days after registration
cb94d43
@Cyperghost
Add user username condition type and associated form field
7a5c603
@Cyperghost
Allow any type as a filter and do not (un)serialize
9276ab6
@Cyperghost
Remove the type ConditionValue and replace it with mixed.
2ed529e
@Cyperghost
Store time/date as unix timestamp
48efdf7
@Cyperghost
Refactor condition type match methods to enforce strict type checking
135ca54
@Cyperghost
Add language variables
715a3e3
@BurntimeX @Cyperghost
Add missing database column for the conditions
65773d2
Cyperghost and others added 29 commits July 14, 2025 10:06
@Cyperghost
Implement migration support for user condition types
9d1c9be
@Cyperghost
Add migration support for user group assignment conditions
508c36f
@Cyperghost
Use a unique structure for the object types for migration.
f85ba58
@Cyperghost
Rename 'needMigration' to 'isLegacy'
e91a9ee
@Cyperghost @dtdesign
Apply suggestions from code review
c6c7ae8 
Co-authored-by: Alexander Ebert <[email protected]>
@Cyperghost
Refactor ConditionMigration
4f105b0
@Cyperghost
Refactor migration condition checks for consistency
aae31ac
@Cyperghost
Refactor condition data migration logic to improve null handling
c63a223
@Cyperghost
Migrate user condition types to use named parameters for improved rea…
713642b 
…dability
@Cyperghost
Add legacy notice for automatic user group assignments and implement …
a47ba70 
…migration worker
@Cyperghost
Rename UserGroupAssignmentMigrateCondition to MigrateLegacyCondition
e9b67b4
@Cyperghost
Fix typo in $field
d6009bb
@Cyperghost
Add error handling for JSON decoding in condition migration
9033e8f
@Cyperghost
Fix incorrect usage of unset function in ConditionHandler
a78416b
@Cyperghost
Use DateTimeImmutable instead of \DateTime
206f69e
@Cyperghost
Expand the PHPDoc for methods in IMigrateConditionType
899599a
@Cyperghost @dtdesign
Apply suggestions from code review
88c4d14 
Co-authored-by: Alexander Ebert <[email protected]>
@Cyperghost
Add a status box if content needs to be recalculated using Rebuild Data.
94550e4
@Cyperghost
Invert check if migrations needed
6d38f37
@dtdesign @Cyperghost
Avoid inheriting from concrete implementations
926d312
@dtdesign @Cyperghost
Fix the class naming to be consistent
13c7979
@dtdesign @Cyperghost
\strtolower() is not binary-safe
d9bf06c
@dtdesign @Cyperghost
Fix the handling of condition types
0f8d751
@dtdesign @Cyperghost
Mark the abstract user conditions as non-abstract
53448d3 
If we're going to instantiate them via anonymous classes, we can just drop the `abstract` because their entire implementation is non-abstract anyway.
@dtdesign @Cyperghost
Register the conditions sequentually
d2c251d 
There is very little gain in offering `addConditions()` plus it requires us to validate an arbitrary array in contrast to relying on `addCondition()` with its type hin.
@dtdesign @Cyperghost
Fix the direction of the comparison
a25534b
@dtdesign @Cyperghost
Simplify the condition names
2b356a4 
Avoiding the repetition makes it easier to find conditions.
@Cyperghost
Rename the class to the correct name
28550ca 
Add phpstan docs
@Cyperghost
Adding language variable
2abe329 
The content of `wcf.condition.add` has been swapped between German and English.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtdesign dtdesign dtdesign requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cyperghost @dtdesign @BurntimeX