Skip to content

Add prometheus integration with ServiceMonitor CRD #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peixian
Copy link
Member

@peixian peixian commented Apr 13, 2025

Adds a ServiceMonitor for HAProxy (https://observability.thomasriley.co.uk/prometheus/configuring-prometheus/using-service-monitors/).

Off by default, can be enabled by users as needed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 13, 2025
@peixian peixian force-pushed the peixian/add-servicemonitor branch from 3771ddd to 472ddf7 Compare April 13, 2025 23:36
# Enables service monitor for the prometheus operator.
enableServiceMonitor: false
prometheus:
release: my-prometheus-release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these be updated in runtime?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the intention is that the user provides their own values.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants