-
Notifications
You must be signed in to change notification settings - Fork 549
Add linter for charts #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Some of these check failures don't look right. It is also checking READMEs. |
|
@@ -11,7 +11,7 @@ jobs: | |||
- name: 'Yamllint' | |||
uses: karancode/yamllint-github-action@master | |||
with: | |||
yamllint_file_or_dir: 'charts/whatsapp-proxy-chart/*/*' | |||
yamllint_file_or_dir: 'charts/whatsapp-proxy-chart/*/*.yml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we need to add *.yaml
here as well because almost all of our files are .yaml
s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about it more, I'm pretty sure helm charts actually fail yamllint, since the interpolation isn't yaml standard. I don't think we can use this, we'll need to do a helm lint
instead per sbaudoin/yamllint#16 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use https://github.com/helm/chart-testing-action instead. Although neither of these would catch the procotcl
misspelling error, as there's no defined spec for it. It'd catch invalid formatting, but not invalid keys.
No description provided.