Skip to content

Add linter for charts #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add linter for charts #357

wants to merge 2 commits into from

Conversation

peixian
Copy link
Member

@peixian peixian commented Feb 19, 2025

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2025
Copy link

yamllint Failed

Show Output
::group::charts/whatsapp-proxy-chart/deployments/README.md
::warning file=charts/whatsapp-proxy-chart/deployments/README.md,line=2,col=1::2:1 [document-start] missing document start "---"
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=2,col=81::2:81 [line-length] line too long (188 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=8,col=1::8:1 syntax error: expected '<document start>', but found '<block mapping start>' (syntax)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=11,col=81::11:81 [line-length] line too long (174 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=18,col=81::18:81 [line-length] line too long (214 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=20,col=81::20:81 [line-length] line too long (153 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=26,col=81::26:81 [line-length] line too long (99 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=30,col=81::30:81 [line-length] line too long (253 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=32,col=81::32:81 [line-length] line too long (227 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=37,col=81::37:81 [line-length] line too long (232 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=38,col=81::38:81 [line-length] line too long (179 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=46,col=81::46:81 [line-length] line too long (182 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=50,col=81::50:81 [line-length] line too long (115 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=52,col=81::52:81 [line-length] line too long (663 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=53,col=2::53:2 [trailing-spaces] trailing spaces
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=54,col=81::54:81 [line-length] line too long (124 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=56,col=81::56:81 [line-length] line too long (138 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=66,col=81::66:81 [line-length] line too long (179 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=68,col=81::68:81 [line-length] line too long (125 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=73,col=81::73:81 [line-length] line too long (241 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=76,col=81::76:81 [line-length] line too long (217 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=79,col=81::79:81 [line-length] line too long (96 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=84,col=81::84:81 [line-length] line too long (156 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=86,col=81::86:81 [line-length] line too long (115 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=88,col=81::88:81 [line-length] line too long (190 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=89,col=2::89:2 [trailing-spaces] trailing spaces
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=90,col=81::90:81 [line-length] line too long (176 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=91,col=2::91:2 [trailing-spaces] trailing spaces
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=92,col=81::92:81 [line-length] line too long (335 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=102,col=81::102:81 [line-length] line too long (128 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=104,col=81::104:81 [line-length] line too long (132 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=119,col=81::119:81 [line-length] line too long (350 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=121,col=81::121:81 [line-length] line too long (173 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=126,col=81::126:81 [line-length] line too long (122 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=129,col=81::129:81 [line-length] line too long (96 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=137,col=81::137:81 [line-length] line too long (103 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=145,col=81::145:81 [line-length] line too long (91 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=149,col=81::149:81 [line-length] line too long (117 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=163,col=81::163:81 [line-length] line too long (86 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=175,col=81::175:81 [line-length] line too long (93 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=176,col=2::176:2 [trailing-spaces] trailing spaces
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=177,col=81::177:81 [line-length] line too long (109 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=178,col=2::178:2 [trailing-spaces] trailing spaces
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=179,col=81::179:81 [line-length] line too long (253 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=180,col=2::180:2 [trailing-spaces] trailing spaces
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=181,col=81::181:81 [line-length] line too long (103 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=188,col=81::188:81 [line-length] line too long (107 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=208,col=81::208:81 [line-length] line too long (168 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=212,col=81::212:81 [line-length] line too long (168 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=214,col=81::214:81 [line-length] line too long (103 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=220,col=81::220:81 [line-length] line too long (168 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=224,col=81::224:81 [line-length] line too long (163 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=228,col=81::228:81 [line-length] line too long (82 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=229,col=81::229:81 [line-length] line too long (190 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=231,col=81::231:81 [line-length] line too long (136 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=241,col=81::241:81 [line-length] line too long (156 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=243,col=81::243:81 [line-length] line too long (115 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=245,col=81::245:81 [line-length] line too long (190 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=246,col=2::246:2 [trailing-spaces] trailing spaces
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=247,col=81::247:81 [line-length] line too long (296 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=248,col=2::248:2 [trailing-spaces] trailing spaces
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=249,col=81::249:81 [line-length] line too long (341 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=253,col=81::253:81 [line-length] line too long (140 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=259,col=81::259:81 [line-length] line too long (122 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=267,col=81::267:81 [line-length] line too long (140 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=272,col=81::272:81 [line-length] line too long (81 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=275,col=81::275:81 [line-length] line too long (144 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=294,col=81::294:81 [line-length] line too long (137 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=296,col=81::296:81 [line-length] line too long (98 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=298,col=81::298:81 [line-length] line too long (82 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=318,col=81::318:81 [line-length] line too long (188 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=319,col=81::319:81 [line-length] line too long (188 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=320,col=81::320:81 [line-length] line too long (195 > 80 characters)
::error file=charts/whatsapp-proxy-chart/deployments/README.md,line=323,col=71::323:71 [new-line-at-end-of-file] no new line character at the end of file
::endgroup::

::group::charts/whatsapp-proxy-chart/deployments/overrides/values.gke.yaml
::error file=charts/whatsapp-proxy-chart/deployments/overrides/values.gke.yaml,line=6,col=81::6:81 [line-length] line too long (91 > 80 characters)
::warning file=charts/whatsapp-proxy-chart/deployments/overrides/values.gke.yaml,line=11,col=1::11:1 [document-start] missing document start "---"
::error file=charts/whatsapp-proxy-chart/deployments/overrides/values.gke.yaml,line=18,col=3::18:3 [indentation] wrong indentation: expected 4 but found 2
::error file=charts/whatsapp-proxy-chart/deployments/overrides/values.gke.yaml,line=20,col=1::20:1 [empty-lines] too many blank lines (1 > 0)
::endgroup::

::group::charts/whatsapp-proxy-chart/deployments/overrides/values.eks.yaml
::warning file=charts/whatsapp-proxy-chart/deployments/overrides/values.eks.yaml,line=11,col=1::11:1 [document-start] missing document start "---"
::error file=charts/whatsapp-proxy-chart/deployments/overrides/values.eks.yaml,line=17,col=1::17:1 [empty-lines] too many blank lines (1 > 0)
::endgroup::

::group::charts/whatsapp-proxy-chart/templates/NOTES.txt
::warning file=charts/whatsapp-proxy-chart/templates/NOTES.txt,line=1,col=1::1:1 [document-start] missing document start "---"
::error file=charts/whatsapp-proxy-chart/templates/NOTES.txt,line=3,col=1::3:1 syntax error: could not find expected ':' (syntax)
::error file=charts/whatsapp-proxy-chart/templates/NOTES.txt,line=10,col=81::10:81 [line-length] line too long (128 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/NOTES.txt,line=14,col=81::14:81 [line-length] line too long (155 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/NOTES.txt,line=15,col=81::15:81 [line-length] line too long (207 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/NOTES.txt,line=18,col=81::18:81 [line-length] line too long (233 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/NOTES.txt,line=19,col=81::19:81 [line-length] line too long (148 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/NOTES.txt,line=21,col=81::21:81 [line-length] line too long (90 > 80 characters)
::endgroup::

::group::charts/whatsapp-proxy-chart/templates/_helpers.tpl
::warning file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=1,col=1::1:1 [document-start] missing document start "---"
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=7,col=1::7:1 syntax error: expected '<document start>', but found '{' (syntax)
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=12,col=8::12:8 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=16,col=81::16:81 [line-length] line too long (105 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=20,col=32::20:32 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=21,col=57::21:57 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=22,col=9::22:9 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=23,col=54::23:54 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=24,col=36::24:36 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=25,col=46::25:46 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=26,col=9::26:9 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=27,col=67::27:67 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=28,col=8::28:8 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=29,col=8::29:8 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=30,col=8::30:8 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=36,col=92::36:92 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=36,col=81::36:81 [line-length] line too long (94 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=37,col=8::37:8 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=43,col=18::43:18 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/_helpers.tpl,line=65,col=81::65:81 [line-length] line too long (86 > 80 characters)
::endgroup::

::group::charts/whatsapp-proxy-chart/templates/deployment.yaml
::warning file=charts/whatsapp-proxy-chart/templates/deployment.yaml,line=5,col=1::5:1 [document-start] missing document start "---"
::error file=charts/whatsapp-proxy-chart/templates/deployment.yaml,line=8,col=11::8:11 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/deployment.yaml,line=8,col=53::8:53 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/deployment.yaml,line=10,col=7::10:7 syntax error: expected the node content, but found '-' (syntax)
::error file=charts/whatsapp-proxy-chart/templates/deployment.yaml,line=12,col=41::12:41 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/deployment.yaml,line=13,col=3::13:3 [indentation] wrong indentation: expected 0 but found 2
::error file=charts/whatsapp-proxy-chart/templates/deployment.yaml,line=13,col=15::13:15 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/deployment.yaml,line=31,col=81::31:81 [line-length] line too long (83 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/deployment.yaml,line=38,col=81::38:81 [line-length] line too long (101 > 80 characters)
::endgroup::

::group::charts/whatsapp-proxy-chart/templates/hpa.yaml
::warning file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=5,col=1::5:1 [document-start] missing document start "---"
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=5,col=3::5:3 syntax error: expected the node content, but found '-' (syntax)
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=9,col=11::9:11 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=9,col=53::9:53 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=11,col=60::11:60 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=16,col=13::16:13 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=16,col=55::16:55 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=17,col=18::17:18 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=17,col=50::17:50 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=18,col=18::18:18 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=18,col=50::18:50 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=20,col=62::20:62 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=21,col=5::21:5 [indentation] wrong indentation: expected 2 but found 4
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=24,col=37::24:37 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=24,col=88::24:88 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=24,col=81::24:81 [line-length] line too long (90 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/hpa.yaml,line=30,col=81::30:81 [line-length] line too long (93 > 80 characters)
::endgroup::

::group::charts/whatsapp-proxy-chart/templates/ingress.yaml
::warning file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=5,col=1::5:1 [document-start] missing document start "---"
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=5,col=3::5:3 syntax error: expected the node content, but found '-' (syntax)
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=8,col=81::8:81 [line-length] line too long (109 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=9,col=3::9:3 [indentation] wrong indentation: expected 0 but found 2
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=9,col=80::9:80 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=9,col=81::9:81 [line-length] line too long (82 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=10,col=3::10:3 [indentation] wrong indentation: expected 0 but found 2
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=10,col=81::10:81 [line-length] line too long (101 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=11,col=3::11:3 [indentation] wrong indentation: expected 0 but found 2
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=11,col=10::11:10 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=12,col=8::12:8 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=13,col=69::13:69 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=30,col=81::30:81 [line-length] line too long (105 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=50,col=81::50:81 [line-length] line too long (100 > 80 characters)
::error file=charts/whatsapp-proxy-chart/templates/ingress.yaml,line=54,col=81::54:81 [line-length] line too long (86 > 80 characters)
::endgroup::

::group::charts/whatsapp-proxy-chart/templates/service.yaml
::warning file=charts/whatsapp-proxy-chart/templates/service.yaml,line=5,col=1::5:1 [document-start] missing document start "---"
::error file=charts/whatsapp-proxy-chart/templates/service.yaml,line=8,col=11::8:11 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/service.yaml,line=8,col=53::8:53 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/service.yaml,line=10,col=7::10:7 syntax error: expected the node content, but found '-' (syntax)
::endgroup::

::group::charts/whatsapp-proxy-chart/templates/serviceaccount.yaml
::warning file=charts/whatsapp-proxy-chart/templates/serviceaccount.yaml,line=5,col=1::5:1 [document-start] missing document start "---"
::error file=charts/whatsapp-proxy-chart/templates/serviceaccount.yaml,line=5,col=3::5:3 syntax error: expected the node content, but found '-' (syntax)
::error file=charts/whatsapp-proxy-chart/templates/serviceaccount.yaml,line=9,col=11::9:11 [braces] too many spaces inside braces
::error file=charts/whatsapp-proxy-chart/templates/serviceaccount.yaml,line=9,col=63::9:63 [braces] too many spaces inside braces
::endgroup::

::group::charts/whatsapp-proxy-chart/templates/tests/test-connection.yaml
::warning file=charts/whatsapp-proxy-chart/templates/tests/test-connection.yaml,line=5,col=1::5:1 [document-start] missing document start "---"
::error file=charts/whatsapp-proxy-chart/templates/tests/test-connection.yaml,line=8,col=22::8:22 syntax error: expected <block end>, but found '<scalar>' (syntax)
::error file=charts/whatsapp-proxy-chart/templates/tests/test-connection.yaml,line=18,col=81::18:81 [line-length] line too long (96 > 80 characters)
::endgroup::

Workflow: Yamllint GitHub Actions, Action: __karancode_yamllint-github-action, Lint: charts/whatsapp-proxy-chart/*/*

@eozturk1
Copy link
Contributor

Some of these check failures don't look right. It is also checking READMEs.

Copy link

yamllint Failed

Show Output

Workflow: Yamllint GitHub Actions, Action: __karancode_yamllint-github-action, Lint: charts/whatsapp-proxy-chart/*/*.yml

@@ -11,7 +11,7 @@ jobs:
- name: 'Yamllint'
uses: karancode/yamllint-github-action@master
with:
yamllint_file_or_dir: 'charts/whatsapp-proxy-chart/*/*'
yamllint_file_or_dir: 'charts/whatsapp-proxy-chart/*/*.yml'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we need to add *.yaml here as well because almost all of our files are .yamls.

Copy link
Member Author

@peixian peixian Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it more, I'm pretty sure helm charts actually fail yamllint, since the interpolation isn't yaml standard. I don't think we can use this, we'll need to do a helm lint instead per sbaudoin/yamllint#16 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use https://github.com/helm/chart-testing-action instead. Although neither of these would catch the procotcl misspelling error, as there's no defined spec for it. It'd catch invalid formatting, but not invalid keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants