Skip to content

Always set display=true when calling NRF.setSecurity. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Always set display=true when calling NRF.setSecurity. #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions characteristic_secure/device_code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ const devicePassKey = '121212'; // 6 digit passkey to use.
let isConnected = false;
let debug = '?';

function canShowPasskey() {
// Without a display this app cannot actually display a passkey, but return
// true because this is required in order to pair using passkeys.
// http://forum.espruino.com/comments/14922430/
return true;
}

function deviceHasDisplay() {
return typeof g !== 'undefined';
}
Expand Down Expand Up @@ -130,9 +137,9 @@ function onInit() {
});

NRF.setSecurity({
display: deviceHasDisplay(), // Can this device display a passkey?
keyboard: false, // Can this device enter a passkey?
mitm: true, // Man In The Middle protection.
display: canShowPasskey(), // Can this device display a passkey?
keyboard: false, // Can this device enter a passkey?
mitm: true, // Man In The Middle protection.
passkey: devicePassKey,
});

Expand Down