feat: use lru_dedup_dict for rank call #569
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
reviewed
Mar 9, 2023
olgavrou
reviewed
Mar 9, 2023
rlclientlib/vw_model/vw_model.cc
Outdated
| return error_code::success; | ||
| } | ||
|
|
||
| int vw_model::add_lru_dedup_cache(uint64_t hash, std::string action_str, api_status* status) |
There was a problem hiding this comment.
We should probably move the "parse action and populate the cache" functionality into vw_model and just have a pointer of it in each vw instance
that way whenever you use vw for a rank call we could just do
auto vw = _vw_pool.get_or_create()
vw.set_action_cache(&action_cache)
vw.rank(...)
There was a problem hiding this comment.
the way it is done here the specific action is only passed into one of the vw instances in the object pool
There was a problem hiding this comment.
removed lru_cache from safe_vw and constructor etc. Added as an arg to load_action and rank in safe_vw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.