Skip to content

Conversation

faridnsh
Copy link
Contributor

This brings back the older behaviour while updating the documentation to explicitly show the pitfall. More context on this issue.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.11%. Comparing base (99d6fe4) to head (820fba1).
Report is 150 commits behind head on master.

Files with missing lines Patch % Lines
cmd/saml2aws/commands/login.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1377       +/-   ##
===========================================
- Coverage   42.19%   28.11%   -14.09%     
===========================================
  Files          54       70       +16     
  Lines        6456    12536     +6080     
===========================================
+ Hits         2724     3524      +800     
- Misses       3283     8535     +5252     
- Partials      449      477       +28     
Flag Coverage Δ
unittests 28.11% <0.00%> (-14.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants