Add post-condition statement #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangneal
reviewed
Oct 23, 2025
| use crate::{ | ||
| halo2::Challenge, | ||
| ir::{expr::Felt, CmpOp}, | ||
| ir::{CmpOp, expr::Felt}, |
There was a problem hiding this comment.
Are these changes being performed by an autoformatter?
There was a problem hiding this comment.
I think yes. IIRC, we added the format config and CI check here but chose not to go back and update formatting in all files at that time since there were large PRs pending. This works since the CI job only checks formatting in the diff.
There was a problem hiding this comment.
Yes, they will trickle down as we make changes for now and can we do one big formatting PR once it's not so busy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a post-condition statement for the Picus backend. This kind of statement is not currently supported in llzk thus I left it unimplemented.