[VEN-1193]: Whitelist Executors #606
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chechu
reviewed
Jul 28, 2025
chechu
reviewed
Jul 28, 2025
chechu
reviewed
Aug 4, 2025
chechu
reviewed
Aug 12, 2025
chechu
reviewed
Aug 12, 2025
chechu
reviewed
Aug 12, 2025
chechu
reviewed
Aug 12, 2025
web3rover
changed the title
kkirka
reviewed
Aug 17, 2025
Comment on lines
149
to
151
| if (receiver != address(0) && whitelistedExecutors[receiver]) { | ||
| return uint256(Error.NO_ERROR); | ||
| } |
There was a problem hiding this comment.
Effects should take place even if the receiver is whitelisted, e.g. even though we defer the liquidity check, we still must add the borrower to the market if it's not there yet. Otherwise the user will have a borrow in the market but we won't account for this borrow in the liquidity check.
kkirka
reviewed
Aug 17, 2025
| ensureListed(market); | ||
|
|
||
| if (liquidator != address(0) && whitelistedExecutors[liquidator]) { | ||
| return uint256(Error.NO_ERROR); |
There was a problem hiding this comment.
Should we still call updateVenusSupplyIndex, distributeSupplierVenus to stop accruing XVS for the supply that no longer exists?
chechu
reviewed
Aug 18, 2025
chechu
reviewed
Aug 18, 2025
Co-authored-by: Jesus Lanchas <[email protected]>
GitGuru7
commented
Aug 18, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ther market
Description
Resolves #
Checklist