[ALL] Fix aliasing undefined behavior for KV uint64 type #1579
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercoms
changed the title
dimhotepus
added a commit
to Source-Authors/Obsoletium
that referenced
this pull request
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed misuse of type punning, this fixes undefined behavior with GCC causing uint64 types to be completely optimized away, resulting in mismatched KeyValues reads from binary due to the skipped value.
This is relevant to Linux clients and servers that send uint64 values as binary over the wire, including for SDK inventory messages and some game stats, usually for the SO item ID.