Fix crash if bonemerging to a pending model #1576
Open
+29
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an entity is bonemerging to a parent whose model has not been loaded yet, this will cause a server crash. This has been a top cause of crashing on a specific community server across various maps.
Specifically this is caused by
CBaseAnimating::SetupBonesnot checking if the model pointer is valid when attempting to fetch the parent's bone cache. This PR introduces a check for validity.In addition, all call sites to
CBaseAnimating::GetBoneCacheare required now to pass the model pointer. This is consistent with the client (seeC_BaseAnimating::GetBoneCache), and also prevents inefficiency, asGetModelPtr()is expensive.