bugfix: component shortcuts #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valian
requested changes
Sep 3, 2025
| // we're looking for a component by exact filename match | ||
| for (const [key, value] of Object.entries(components)) { | ||
| if (key.endsWith(`${name}.vue`) || key.endsWith(`${name}/index.vue`)) { | ||
| const fileName = key.split('/').pop() // Get the actual filename |
Owner
There was a problem hiding this comment.
I understand why you've done it, but I can explain the reason for the previous behaviour.
Imagine you have two components, components/workspaces/List.vue and conponents/accounts/List.vue.
With my previous approach, you could type either full path or just last unambigious part. With yours I think it's no longer possible.
But!
I think you can adjust it. Something along the lines to split both candidate and searched component by / and try to match starting from last index.
Would be great if you (or AMP) could do it ;)
Contributor
Author
There was a problem hiding this comment.
Ah yeah that makes sense. I'll cook something up later that supports both workflows :)
Owner
|
Hi @cschmatzler, any updates on this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findComponentpreviously usedendsWith()- this caused conflicts with my two componentsWorkspace.vueandCreateWorkspace.vue. This PR makes the handling more exact.Disclaimer: this was mostly debugged and implemented by an LLM - see https://ampcode.com/threads/T-3b8af23a-35e8-45cf-a7b4-6e4b175da0d6