Skip to content

Conversation

aurreco-uga
Copy link
Member

No description provided.

Copy link
Member

@dmfalke dmfalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment below...

Comment on lines -99 to +100
return isIndividual(node) ? node.wdkReference.help
return isIndividual(node) ? node.wdkReference.description
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why we were returning help here? Was there a good reason for it?

Copy link
Contributor

@jtlong3rd jtlong3rd Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that it has to do with the current implementation of getTooltipContent - in that function, we seem to be delegating to getDescription when the node either (1) isn't an individual or (2) doesn't have a "search" property.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. I think it also has to do with the fact that AttributeField doesn't have a description property. I think we might need to have some branching logic based on the type of wdkReference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the help is for attributes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summary for questions.... for questions we would not want to deal with description...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants