Skip to content

VPS 115/make z axis more intuitive #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

hazikchaudhry
Copy link
Contributor

Describe the issue

The authoring tool's component properties sidebar featured form fields to manage Z-position. This meant users could not reliably manage component stacking order (e.g., incremental moves, send to front/back), hindering efficient scene layout.

Describe the solution

A standardised Z-axis control module was implemented across relevant component property sidebars (Button, Image, Text, SpeechText, FirebaseAudio). This module provides:

  • Display of the current zPosition.
  • Buttons for incremental ("Move Backward"/"Forward") and absolute ("Send to Back"/"Bring to Front") layering.
  • Logic to prevent redundant updates if already at min/max Z-depth.
  • All controls are now grouped under a single "Z Axis Position" heading with consistent styling, replacing previous Z-axis inputs. Component files were refactored to support this.

Risk

Performance: In scenes with a very large number of components, the "Send to Back" / "Bring to Front" actions (which scan all components to determine min/max Z-values) might introduce a minor UI delay. Should not be that much of a delay.

Image Bug: Beforehand images did not respond to Z-position changes, currently this system has the same issue. It may have something to do with their state management within the scene/slide. Due to selection errors being present when an image is selected.

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Copy link
Contributor

@becky-n becky-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@harbassan harbassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try and extract the reused code out into its own component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants