-
Notifications
You must be signed in to change notification settings - Fork 0
VPS 115/make z axis more intuitive #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…c to calculate the min/max z values for each slide, only for the button components for now
…lso added a z axis indicator for debugging
…still do not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try and extract the reused code out into its own component
Co-authored-by: Becky <[email protected]>
Co-authored-by: Becky <[email protected]>
…th contributor details
… component methods to use them
Describe the issue
The authoring tool's component properties sidebar featured form fields to manage Z-position. This meant users could not reliably manage component stacking order (e.g., incremental moves, send to front/back), hindering efficient scene layout.
Describe the solution
A standardised Z-axis control module was implemented across relevant component property sidebars (Button, Image, Text, SpeechText, FirebaseAudio). This module provides:
Risk
Performance: In scenes with a very large number of components, the "Send to Back" / "Bring to Front" actions (which scan all components to determine min/max Z-values) might introduce a minor UI delay. Should not be that much of a delay.
Image Bug: Beforehand images did not respond to Z-position changes, currently this system has the same issue. It may have something to do with their state management within the scene/slide. Due to selection errors being present when an image is selected.
Definition of Done
Reviewed By
Who reviewed your PR - for commit history once merged