fix: Do not hardcode file extension on temp files #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor fix to improve our logging. When we buffer a file like input to disk in `process_data_with_model`, we always use the name `document.pdf`. This confused me when I found this in our logs: ``` 2025-06-30 17:02:01,906 unstructured_inference INFO Reading image file: /var/folders/5k/frv076q97yl0ywybmzydhbsr0000gn/T/tmpc0uq7zde/document.pdf ... 2025-06-30 17:02:01,951 unstructured_api ERROR cannot identify image file '/private/var/folders/5k/frv076q97yl0ywybmzydhbsr0000gn/T/tmpc0uq7zde/document.pdf' ``` This path can be either pdfs or images, so let's just drop the extension to save ourselves some confusion. Also added a comment so we don't forget why it's using a temp dir, not a temp file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor fix to improve our logging. When we buffer a file like input to disk in
process_data_with_model, we always use the namedocument.pdf. This confused me when I found this in our logs:This path can be either pdfs or images, so let's just drop the extension to save ourselves some confusion.
Also added a comment so we don't forget why it's using a temp dir, not a temp file.