FIX: Fixed ISXB-586 for 2022.3.69f1 and up.

[benoitalain]

Description

Original PR: #1975

Jira ticket: https://jira.unity3d.com/browse/ISXB-586
2022.3 PR: https://github.cds.internal.unity3d.com/unity/unity/pull/81547

2022.3 PR has successfully landed before this PR.

Testing status & QA

Adds 2022.3.69f1 to #define flag UNITY_INPUT_SYSTEM_SENDPOINTERHOVERTOPARENT which was used in original fix.

From the original fix:
Implements BaseInputModule sendPointerHoverToParent property for InputSystemUIInputModule. Also properly set PointerEventData reentered and fullyExited properties.

Overall Product Risks

• Complexity: 0
• Halo Effect: 1

Comments to reviewers

I did not do any kind of testing whatsoever on this backport fix.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

After merge:

• Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

[u-pr-agent]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪ The visible change is minimal, but the changelog entry contains multiple errors and the PR description states no testing was performed, requiring careful validation.

🏅 Score: 25 The PR is a simple backport, but the changelog entry has typos, placeholders, and an incorrect issue reference, and the author explicitly stated no testing was done.

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Changelog Inaccuracies The new changelog entry has several issues that need correction: A typo: "was was". A placeholder version: "2022.3.XX". An incorrect Jira ticket reference: "[ISXB-1296]" is used, but the PR is for "ISXB-586". - Fixed InputSystemUIInputModule calling pointer events on parent objects even when the "Send Pointer Hover To Parent" is off on 2022.3.XX. This was was previously only available on Unity 6 versions since 1.11.0. [ISXB-1296]

---

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

[u-pr-agent]

PR Code Suggestions ✨

No code suggestions found for the PR.

[benoitalain]

@Pauliusd01 I added you for QA. Could you verify

• 2022.3.68f1 and below don't have the fix but also don't get compile errors when using InputSystem package with this branch
• 2022.3.69f1 has the fix
• 6000.0.14f1 and below don't have the fix but also don't get compile errors when using InputSystem package with this branch
• 6000.0.15f1 or more still has the fix

Or test 2022.3.69f1 and for other versions just trust the process that we'll get bug reports if I regressed anything. The risk of that is pretty low.

[codecov-github-com]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2261      +/-   ##
===========================================
- Coverage    76.70%   76.63%   -0.08%     
===========================================
  Files          465      472       +7     
  Lines        87919    88278     +359     
===========================================
+ Hits         67442    67648     +206     
- Misses       20477    20630     +153     

Flag	Coverage Δ
inputsystem_MacOS_2021.3	5.90% <ø> (-0.01%)	⬇️
inputsystem_MacOS_2022.3	5.37% <ø> (-0.01%)	⬇️
inputsystem_MacOS_2022.3_project	74.56% <ø> (-0.03%)	⬇️
inputsystem_MacOS_6000.0	5.18% <ø> (-0.01%)	⬇️
inputsystem_MacOS_6000.0_project	76.43% <ø> (-0.08%)	⬇️
inputsystem_MacOS_6000.2	5.18% <ø> (-0.01%)	⬇️
inputsystem_MacOS_6000.2_project	76.43% <ø> (-0.08%)	⬇️
inputsystem_MacOS_6000.3	5.18% <ø> (-0.01%)	⬇️
inputsystem_MacOS_6000.3_project	76.43% <ø> (-0.08%)	⬇️
inputsystem_MacOS_6000.4	5.18% <ø> (-0.01%)	⬇️
inputsystem_MacOS_6000.4_project	76.43% <ø> (-0.08%)	⬇️
inputsystem_Ubuntu_2021.3	5.91% <ø> (-0.01%)	⬇️
inputsystem_Ubuntu_2022.3	5.37% <ø> (-0.01%)	⬇️
inputsystem_Ubuntu_2022.3_project	74.36% <ø> (-0.03%)	⬇️
inputsystem_Ubuntu_6000.0	5.19% <ø> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.0_project	76.24% <ø> (-0.08%)	⬇️
inputsystem_Ubuntu_6000.2	5.19% <ø> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.2_project	76.25% <ø> (-0.07%)	⬇️
inputsystem_Ubuntu_6000.3	5.19% <ø> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.3_project	76.24% <ø> (-0.08%)	⬇️
inputsystem_Ubuntu_6000.4	5.19% <ø> (-0.01%)	⬇️
inputsystem_Ubuntu_6000.4_project	76.24% <ø> (-0.08%)	⬇️
inputsystem_Windows_2021.3	5.90% <ø> (-0.01%)	⬇️
inputsystem_Windows_2022.3	5.37% <ø> (-0.01%)	⬇️
inputsystem_Windows_2022.3_project	74.70% <ø> (-0.03%)	⬇️
inputsystem_Windows_6000.0	5.18% <ø> (-0.01%)	⬇️
inputsystem_Windows_6000.0_project	76.57% <ø> (-0.08%)	⬇️
inputsystem_Windows_6000.2	5.18% <ø> (-0.01%)	⬇️
inputsystem_Windows_6000.2_project	76.57% <ø> (-0.08%)	⬇️
inputsystem_Windows_6000.3	5.18% <ø> (-0.01%)	⬇️
inputsystem_Windows_6000.3_project	76.57% <ø> (-0.08%)	⬇️
inputsystem_Windows_6000.4	5.18% <ø> (-0.01%)	⬇️
inputsystem_Windows_6000.4_project	76.57% <ø> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ericksson]

Cancelling all jobs running on this branch due to Android jobs being broken and stuck - see https://unity.slack.com/archives/C94RMJJ5T/p1760644095487229

Follow that thread to see when Lukas has a fix for the issue. Please refrain from rerunning the tests until the fix is available and you have it merged in this branch.