Skip to content

Added direction reference attribute #7469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added direction reference attribute #7469

wants to merge 2 commits into from

Conversation

Vic-Cooper
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@Vic-Cooper Vic-Cooper requested a review from markg-unity June 8, 2022 08:53
@markg-unity
Copy link
Contributor

markg-unity commented Jun 8, 2022 •
edited
Loading

Looks good! Couple of questions:

  • Is it possible to use <ul> and <li> instead of the <br>s and manual bullets? (I'm guessing probably not?)
  • Should 'Set Position (Shape : Circle)' use code formatting?

markg-unity
markg-unity reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@markg-unity markg-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Vic-Cooper Vic-Cooper changed the base branch from master to 10.x.x/release June 10, 2022 10:35
@Vic-Cooper Vic-Cooper requested review from a team as code owners June 10, 2022 10:35
@Vic-Cooper Vic-Cooper changed the base branch from 10.x.x/release to master June 10, 2022 10:36
@Vic-Cooper Vic-Cooper changed the base branch from master to 10.x.x/release June 10, 2022 10:39
@Vic-Cooper Vic-Cooper changed the base branch from 10.x.x/release to master June 10, 2022 10:57
@theopnv theopnv removed the request for review from a team June 10, 2022 14:52
@sebastienlagarde
Copy link
Contributor

@Vic-Cooper / @markg-unity I suppose we must close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellioman ellioman ellioman approved these changes

@markg-unity markg-unity markg-unity approved these changes

Assignees
No one assigned
Labels
vfx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vic-Cooper @markg-unity @sebastienlagarde @ellioman