-
Notifications
You must be signed in to change notification settings - Fork 24
More fixes for real applications #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
val resolvedArgs = expr.args.map { resolve(it) ?: return null } | ||
|
||
val staticInstances = scope.calcOnState { | ||
resolutionResult.properties.take(1).map { getStaticInstance(it.enclosingClass!!) } |
Check warning
Code scanning / detekt
Unsafe calls on nullable types detected. These calls will throw a NullPointerException in case the nullable value is null. Warning
|
||
require(resolutionResult is EtsPropertyResolution.Unique) | ||
|
||
val instance = scope.calcOnState { getStaticInstance(resolutionResult.property.enclosingClass!!) } |
Check warning
Code scanning / detekt
Unsafe calls on nullable types detected. These calls will throw a NullPointerException in case the nullable value is null. Warning
} | ||
|
||
// Если мы записали что-то в объект в виде bool, а потом считали это из поля bool | null, то здесь будет unresolvedSort, |
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style. Warning
@@ -72,11 +75,27 @@ | |||
.filterNot { it.isStatic } | |||
.filterNot { it.name.startsWith("%AM") } | |||
.filterNot { it.name == "build" } | |||
.filterNot { it.name == INSTANCE_INIT_METHOD_NAME } |
Check warning
Code scanning / detekt
Disallow shadowing variable declarations. Warning test
@@ -72,11 +75,27 @@ | |||
.filterNot { it.isStatic } | |||
.filterNot { it.name.startsWith("%AM") } | |||
.filterNot { it.name == "build" } | |||
.filterNot { it.name == INSTANCE_INIT_METHOD_NAME } | |||
.filterNot { it.name == STATIC_INIT_METHOD_NAME } |
Check warning
Code scanning / detekt
Disallow shadowing variable declarations. Warning test
@@ -72,11 +75,27 @@ | |||
.filterNot { it.isStatic } | |||
.filterNot { it.name.startsWith("%AM") } | |||
.filterNot { it.name == "build" } | |||
.filterNot { it.name == INSTANCE_INIT_METHOD_NAME } | |||
.filterNot { it.name == STATIC_INIT_METHOD_NAME } | |||
.filterNot { it.name == CONSTRUCTOR_NAME } |
Check warning
Code scanning / detekt
Disallow shadowing variable declarations. Warning test
@@ -233,7 +233,7 @@ | |||
pathSelectionStrategies = listOf(PathSelectionStrategy.CLOSEST_TO_UNCOVERED_RANDOM), | |||
exceptionsPropagation = true, | |||
timeout = Duration.INFINITE, | |||
stepsFromLastCovered = 3500L, | |||
stepsFromLastCovered = 50000L, |
Check warning
Code scanning / detekt
Report missing or invalid underscores in base 10 numbers. Numeric literals should be underscore separated to increase readability. Warning test
options, | ||
targets, | ||
timeStatisticsFactory = | ||
{ timeStatistics }, |
Check warning
Code scanning / detekt
Reports mis-indented code Warning
timeStatisticsFactory = | ||
{ timeStatistics }, | ||
stepsStatisticsFactory = | ||
{ stepsStatistics }, |
Check warning
Code scanning / detekt
Reports mis-indented code Warning
stepsStatisticsFactory = | ||
{ stepsStatistics }, | ||
coverageStatisticsFactory = | ||
{ coverageStatistics }, |
Check warning
Code scanning / detekt
Reports mis-indented code Warning
coverageStatisticsFactory = | ||
{ coverageStatistics }, | ||
getCollectedStatesCount = | ||
{ statesCollector.collectedStates.size } |
Check warning
Code scanning / detekt
Reports mis-indented code Warning
@@ -202,12 +204,14 @@ | |||
concreteMethods += methods | |||
} | |||
|
|||
val limitedConcreteMethods = concreteMethods.take(5) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
5ed9332
to
eb8e80e
Compare
No description provided.