Skip to content

Replaced access path bases with access paths in backward dataflow #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MForest7
Copy link
Collaborator

Replaced nested objects in backward dataflow with access paths, also get a performance increase.

project stmts min time max time avg time median time %
project1 9914 1.4s 1.8s 1.6s 1.5s 39.4
project2 26679 1.3s 1.5s 1.4s 1.4s 16.5
project3 4272 0.3s 0.4s 0.4s 0.4s 28.8
project4 4584 0.3s 0.4s 0.3s 0.3s 35.6
project5 121091 8.9s 9.8s 9.3s 9.0s 37.4
project6 28548 1.6s 1.8s 1.7s 1.7s 38.9
project7 5162 0.4s 0.4s 0.4s 0.4s 28.0

@MForest7 MForest7 requested a review from Lipen May 28, 2025 15:59
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@Lipen
Copy link
Member

Lipen commented May 30, 2025

What does the % mean in the table? Replace the table with fewer columns: project, size (stmts or similar), old time (avg +- sd), new time (avg +- sd). If the deviation is low (and it should be low, since the analysis should be near-deterministic), it can be omitted.

What about the "quality"? Comparing only the performance is not enough for such major change. Pick a metric (number of inferred types, ratio of all type, ratio of annotated type, number of inferred calls, etc) and add "old/new quality" columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants