Order queue fix and speedmining tweaks #96
+110
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Commander.commands` being a hashmap causes orders to be passed to sc2 in hash order (i.e. basically random), causing queued orders to be delivered in the wrong order about 50% of the time. This prevented implementing the key speedmining boost trick, which is to queue the `smart` command on top of the `move` command. With this fix in place, and the speedmining boost implemented, the speedmining example increases from a 3% bonus to an 8% bonus (the same speed up that Ares achieves in the Python world).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commander.commandsbeing a hashmap causes orders to be passed to sc2 in hash order (i.e. basically random), causing queued orders to be delivered in the wrong order about 50% of the time.This prevented implementing the key speedmining boost trick, which is to queue the
smartcommand on top of themovecommand.With this fix in place, and the speedmining boost implemented, the speedmining example increases from a 3% bonus to an 8% bonus (the same speed up that Ares achieves in the Python world).