first pass at a BNFC grammar for the rASL AST format #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agle
reviewed
Sep 8, 2025
| (targets AbsSemantics.ml LexSemantics.mll ParSemantics.mly SkelSemantics.ml PrintSemantics.ml ShowSemantics.ml TestSemantics.ml BNFC_Util.ml Makefile) | ||
| (mode promote) | ||
| (enabled_if %{env:ASLP_BNFC_PROMOTE=false})) | ||
| ; NOTE: bnfc is not run unless ASLP_BNFC_PROMOTE is manually set to `true`. |
There was a problem hiding this comment.
--makefile could probably be replaced with a trivial dune executable depending on libASL_bnfc.
agle
reviewed
Sep 8, 2025
libASL/dune
Outdated
| (flags (:standard -w -27)) | ||
| (modules asl_ast asl_parser asl_parser_pp asl_utils asl_visitor visitor utils value primops symbolic) | ||
| (libraries pprint (re_export zarith))) | ||
| (libraries pprint (re_export zarith) libASL_bnfc)) |
There was a problem hiding this comment.
Probably want libSAL_bnfc to be a separate library so that it can be installed independently without Z3?
There was a problem hiding this comment.
It is, it's just used as a dependency here.
libASL/dune
Outdated
| (preprocessor_deps (alias ../asl_files) (alias cpp_backend_files) ../offlineASL/template_offline_utils.ml) | ||
| (preprocess (pps ppx_blob)) | ||
| (libraries libASL_stage0 libASL_support str mlbdd)) | ||
| (libraries libASL_stage0 libASL_support str mlbdd unix)) |
There was a problem hiding this comment.
Oops, yes. That shouldn't be there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(the AST format is the one that looks like this:
Stmt_ConstDecl(Type_Bits(64),"Cse0__5",Expr_TApply("add_bits.0",...and is used in gtirb-semantics and BASIL)This adds a BNFC grammar to gain all the benefits of BNFC, most importantly, multi-language parser generator generating. This is the same language which is described in Semantics.g4, but BNFC brings some improvements and I've also just written a better grammar this time.
Some notes:
Tested by running through all the AST outputs in
test_cntlm.tand also by adding a BNFC parse to the coverage checking. This passes with no problems, so we can be sure that the BNFC grammar describes a superset of the AST which we see in coverage.